Upgrade action start resume part2 #2647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
升级 start/resume action
添加 shell 脚本 L229 --alloc|--lock|--chunksize|--chunktime 选项。
在 async-profiler 中，"include only user-mode events" 功能对应的 JVM TI 格式参数为 alluser 但 CLI 选项为
--all-user（shell 脚本 L240）。目前 arthas 中 CLI 格式为--alluser，是否考虑更换为兼容上游的格式？另外，arthas 实现了
--allkernel选项，但 async-profiler 的 README 和命令 help message 中都没有这个选项，具体原因可参考 Why allkernel option is not in README or help message?，是否考虑去掉该选项？相关 issue
issue #2164