Implementing start_switch_fiber and finish_switch_fiber for uthread to enable address sanitizer #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RainMark
reviewed
Dec 23, 2022
async_simple/CMakeLists.txt
Outdated
| @@ -11,7 +11,7 @@ if(${UTHREAD}) | |||
| # for the user thread. | |||
| # FIXME2: the new added sanitize action: address-use-after-return | |||
RainMark
reviewed
Dec 23, 2022
| #ifdef AS_INTERNAL_USE_ASAN | ||
| const void* asan_stack_bottom = nullptr; | ||
| std::size_t asan_stack_size = 0; | ||
| void* asan_fack_stack = nullptr; |
|
thanks，rest lgtm |
…o enable address sanitizer
RainMark
approved these changes
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Closes #178
What is changing
Example