fix(react): remove the cleanup of ShadowSVG's effect #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for designable-fusion ready! 🔨 Explore the source changes: 7d77533 🔍 Inspect the deploy log: https://app.netlify.com/sites/designable-fusion/deploys/61b0595a4c2188000700a63f 😎 Browse the preview: https://deploy-preview-162--designable-fusion.netlify.app/ |
|
✔️ Deploy Preview for designable-antd ready! 🔨 Explore the source changes: 7d77533 🔍 Inspect the deploy log: https://app.netlify.com/sites/designable-antd/deploys/61b0595a956ea700074311b2 😎 Browse the preview: https://deploy-preview-162--designable-antd.netlify.app/ |
DivXPro
added a commit
to toy-box/designable
that referenced
this pull request
Dec 22, 2021
* main: chore(versions): 😊 publish v1.0.0-beta.42 feat: support setNpmCDNRegistry chore(versions): 😊 publish v1.0.0-beta.41 fix: fix isBehavior fix(formily): set default language (alibaba#163) fix(react): remove the cleanup of ShadowSVG's effect (alibaba#162) chore(versions): 😊 publish v1.0.0-beta.40 chore: add sandbox example fix(react): fix NodePathWidget style fix(react): fix root style fix(react): fix prettier cdn version chore(versions): 😊 publish v1.0.0-beta.39 fix(react): create attach-shadow repeatedly (alibaba#161) chore(versions): 😊 publish v1.0.0-beta.38 fix(react): fix position props in StudioPanel (alibaba#155) chore: improve node reisze feat: support resizable to designerProps fix(react): fix studiopanel className setting (alibaba#153)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
我在将 designable 用在 umi 项目中发现会报错
Uncaught DOMException: Failed to execute 'attachShadow' on 'Element': Shadow root cannot be created on a host which already hosts a shadow tree.，调查了一下发现在已经attachShadow的元素上再次调用attachShadow会报错这个错误。我试了一下 普通情况 无法复现这个问题，因为
ref.current总是null.main.npm test).npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.