bug fixed for 'is' prefix fieldName parser. for issue #1529

alibaba · Oct 21, 2017 · e0640e5 · e0640e5
1 parent 51da853
commit e0640e5
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/src/main/java/com/alibaba/fastjson/parser/JavaBeanDeserializer.java b/src/main/java/com/alibaba/fastjson/parser/JavaBeanDeserializer.java
@@ -929,7 +929,8 @@ private boolean parseField(DefaultJSONParser parser, String key, Object object,
             // smartMatchHashArrayMapping
 
             int pos = Arrays.binarySearch(smartMatchHashArray, smartKeyHash);
-            if (pos < 0 && key.startsWith("is")) {
+            boolean is = false;
+            if (pos < 0 && (is = key.startsWith("is"))) {
                 smartKeyHash = TypeUtils.fnv_64_lower(key.substring(2));
                 pos = Arrays.binarySearch(smartMatchHashArray, smartKeyHash);
             }
@@ -951,6 +952,10 @@ private boolean parseField(DefaultJSONParser parser, String key, Object object,
                 int deserIndex = smartMatchHashArrayMapping[pos];
                 if (deserIndex != -1) {
                     fieldDeserializer = sortedFieldDeserializers[deserIndex];
+                    Class fieldClass = fieldDeserializer.fieldInfo.fieldClass;
+                    if (is && (fieldClass != boolean.class && fieldClass != Boolean.class)) {
+                        fieldDeserializer = null;
+                    }
                 }
             }
         }

diff --git a/src/test/java/com/alibaba/json/bvt/issue_1500/Issue1529.java b/src/test/java/com/alibaba/json/bvt/issue_1500/Issue1529.java
@@ -0,0 +1,17 @@
+package com.alibaba.json.bvt.issue_1500;
+
+import com.alibaba.fastjson.JSON;
+import junit.framework.TestCase;
+
+public class Issue1529 extends TestCase {
+    public void test_for_issue() throws Exception {
+        String text = "{\"isId\":false,\"Id\":138042533,\"name\":\"example\",\"height\":172}";
+        JSON.parseObject(text, Person.class);
+    }
+
+    public static class Person {
+        public int Id;
+        public String name;
+        public double height;
+    }
+}