Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1500 #1506

Merged
merged 2 commits into from
Oct 4, 2017
Merged

fix #1500 #1506

merged 2 commits into from
Oct 4, 2017

Conversation

kimmking
Copy link
Contributor

@kimmking kimmking commented Oct 2, 2017

add exception fields processing

@codecov-io
Copy link

Codecov Report

Merging #1506 into master will decrease coverage by <.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1506      +/-   ##
============================================
- Coverage     82.79%   82.78%   -0.01%     
+ Complexity     6026     6025       -1     
============================================
  Files           136      136              
  Lines         22043    22049       +6     
  Branches       5034     5034              
============================================
+ Hits          18250    18253       +3     
  Misses         2552     2552              
- Partials       1241     1244       +3
Impacted Files Coverage Δ Complexity Δ
...son/parser/deserializer/ThrowableDeserializer.java 92% <83.33%> (-0.56%) 32 <0> (ø)
...com/alibaba/fastjson/parser/JSONReaderScanner.java 72.61% <0%> (-1.28%) 44% <0%> (-1%)
...m/alibaba/fastjson/serializer/SerializeWriter.java 89.05% <0%> (-0.09%) 371% <0%> (-1%)
...ava/com/alibaba/fastjson/parser/JSONLexerBase.java 71.52% <0%> (+0.03%) 785% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d35a1a1...4fc5587. Read the comment docs.

@wenshao
Copy link
Member

wenshao commented Oct 3, 2017

ThrowableDeserializer是每个class一个的,可以在实例级别对Field做缓存么?从反射中获取field会很慢的

@kimmking
Copy link
Contributor Author

kimmking commented Oct 3, 2017

可以考虑,目前这么处理是因为:一般的逻辑是走不到新加的处理里面来的。

@wenshao wenshao merged commit a3860da into alibaba:master Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants