This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
修改 DateCodec 判断 dateFormat 长度的逻辑 #3362
Open
vdiskg
wants to merge
4
commits into
alibaba:master
Choose a base branch
from
vdiskg:issues/#3361
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3362 +/- ##
============================================
- Coverage 80.47% 80.46% -0.01%
Complexity 7454 7454
============================================
Files 157 157
Lines 27840 27847 +7
Branches 6708 6708
============================================
+ Hits 22404 22408 +4
- Misses 3423 3425 +2
- Partials 2013 2014 +1
Continue to review full report at Codecov.
|
ZivYan
reviewed
Jul 25, 2020
private void test(String format) { | ||
Demo demo = new Demo(); | ||
demo.setDate(new java.util.Date()); | ||
JSON.DEFFAULT_DATE_FORMAT = format; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
你这样不是线程安全的诶,其实从全局角度来说我觉得还是在字段上面定义格式会更香一点
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
你这样不是线程安全的诶,其实从全局角度来说我觉得还是在字段上面定义格式会更香一点
我认为全局的格式应当是在初始化阶段设置的,运行期间不应该去改这个值,test里面这么做仅仅是为了验证一下这两种情况都能正确处理而已,实际使用的时候肯定是定死一个值再也不会去改它的。
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3361
修改 DateCodec 判断 dateFormat 长度的逻辑,以解决 dateFormatPattern 当中含有 [单引号、Z ] 等导致的长度判断错误