Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix replace Collections.EmptyList with ArrayList for issue #1835 #1837

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

yanxutao89
Copy link
Collaborator

What this PR does / why we need it?

fix replace Collections.EmptyList with ArrayList for issue #1835

Summary of your change

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.18% 🎉

Comparison is base (1648934) 73.23% compared to head (4bd19c5) 73.42%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1837      +/-   ##
============================================
+ Coverage     73.23%   73.42%   +0.18%     
+ Complexity    21495    21414      -81     
============================================
  Files           646      634      -12     
  Lines         87376    86874     -502     
  Branches      19065    18983      -82     
============================================
- Hits          63990    63784     -206     
+ Misses        15468    15188     -280     
+ Partials       7918     7902      -16     
Files Changed Coverage Δ
...alibaba/fastjson2/reader/ObjectReaderImplList.java 78.01% <100.00%> (ø)

... and 25 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wenshao wenshao merged commit afac453 into alibaba:main Sep 6, 2023
3 checks passed
@yanxutao89 yanxutao89 deleted the fix-1835 branch September 22, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants