Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fix Issue1819 #1864

Merged
merged 3 commits into from
Sep 16, 2023
Merged

Fix: Fix Issue1819 #1864

merged 3 commits into from
Sep 16, 2023

Conversation

a1batr0ss
Copy link
Contributor

@a1batr0ss a1batr0ss commented Sep 14, 2023

What this PR does / why we need it?

修补Issue #1819

Summary of your change

从byte[]解析32位整数时,offset没有后移,此时offset对应的是valueType。

@CLAassistant
Copy link

CLAassistant commented Sep 14, 2023

CLA assistant check
All committers have signed the CLA.

@wenshao
Copy link
Member

wenshao commented Sep 14, 2023

本地执行mvn validate修复下checkstyle问题

@wenshao wenshao added this to the 2.0.41 milestone Sep 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (8953c18) 73.24% compared to head (2cf71cb) 73.25%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1864   +/-   ##
=========================================
  Coverage     73.24%   73.25%           
- Complexity    21504    21511    +7     
=========================================
  Files           646      646           
  Lines         87376    87385    +9     
  Branches      19065    19067    +2     
=========================================
+ Hits          64001    64012   +11     
+ Misses        15459    15456    -3     
- Partials       7916     7917    +1     
Files Changed Coverage Δ
...in/java/com/alibaba/fastjson2/JSONReaderJSONB.java 73.52% <100.00%> (+0.11%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wenshao wenshao merged commit 80bd810 into alibaba:main Sep 16, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants