Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix jsonb deserialize error on null list field ,for issue #2181 #2184

Merged
merged 4 commits into from
Jan 15, 2024

Conversation

rowstop
Copy link
Contributor

@rowstop rowstop commented Jan 13, 2024

What this PR does / why we need it?

fix jsonb deserialize error on null list field ,for issue #2181

Summary of your change

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c10c354) 75.36% compared to head (0bab4ae) 75.36%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2184   +/-   ##
=========================================
  Coverage     75.36%   75.36%           
- Complexity    21676    21678    +2     
=========================================
  Files           634      634           
  Lines         85493    85495    +2     
  Branches      18961    18962    +1     
=========================================
+ Hits          64429    64437    +8     
+ Misses        13135    13131    -4     
+ Partials       7929     7927    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wenshao
Copy link
Member

wenshao commented Jan 13, 2024

可以补充testcase么?

@wenshao
Copy link
Member

wenshao commented Jan 15, 2024

能否通过修复去掉多余空格,extends前换行等问题,不需要在pom.xml excludes的方式解决checkstyle的问题。本地执行mvn validate检验根据错误提示修改也挺方便的。

@rowstop
Copy link
Contributor Author

rowstop commented Jan 15, 2024

能否通过修复去掉多余空格,extends前换行等问题,不需要在pom.xml excludes的方式解决checkstyle的问题。本地执行mvn validate检验根据错误提示修改也挺方便的。

我用了,他跟#2181 提供的testcase 就不能保持一致了,要求我用 final 修饰字段
image

@wenshao wenshao merged commit 297b55d into alibaba:main Jan 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants