Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix getBigDecimal with Boolean, for issue #2745 #2746

Merged
merged 2 commits into from
Jun 29, 2024
Merged

fix getBigDecimal with Boolean, for issue #2745 #2746

merged 2 commits into from
Jun 29, 2024

Conversation

Cooper-Zhong
Copy link
Contributor

@Cooper-Zhong Cooper-Zhong commented Jun 27, 2024

What this PR does / why we need it?

Improve fastjson-compatible, fix getBigDecimal with Boolean, for issue #2745
support Boolean for getInteger, getBigInteger and getBigDecimal.

Summary of your change

fastjson1-compatible/src/main/java/com/alibaba/fastjson/JSONArray.java
fastjson1-compatible/src/main/java/com/alibaba/fastjson/JSONObject.java
core/src/main/java/com/alibaba/fastjson2/JSONObject.java
core/src/main/java/com/alibaba/fastjson2/JSONArray.java

support Boolean for getInteger, getBigInteger and getBigDecimal.

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

@CLAassistant
Copy link

CLAassistant commented Jun 27, 2024

CLA assistant check
All committers have signed the CLA.

@wenshao
Copy link
Member

wenshao commented Jun 27, 2024

JSONObject类也要一并改了

@Cooper-Zhong
Copy link
Contributor Author

好的 我修改一下

@wenshao wenshao merged commit 27724a6 into alibaba:main Jun 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants