Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 3208 #3241

Merged
merged 3 commits into from
Jan 1, 2025
Merged

Fix 3208 #3241

merged 3 commits into from
Jan 1, 2025

Conversation

wenshao
Copy link
Member

@wenshao wenshao commented Jan 1, 2025

What this PR does / why we need it?

Summary of your change

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

@wenshao wenshao merged commit 5644769 into main Jan 1, 2025
28 checks passed
@codecov-commenter
Copy link

codecov-commenter commented Jan 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.82%. Comparing base (9728cd4) to head (189e1dd).
Report is 8 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3241      +/-   ##
============================================
+ Coverage     74.77%   74.82%   +0.05%     
- Complexity    23865    23890      +25     
============================================
  Files           668      668              
  Lines         92224    92230       +6     
  Branches      20622    20623       +1     
============================================
+ Hits          68956    69013      +57     
+ Misses        15006    14967      -39     
+ Partials       8262     8250      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants