Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kotlin constructor parameter supports default value #370 #373

Merged
merged 1 commit into from
May 28, 2022
Merged

kotlin constructor parameter supports default value #370 #373

merged 1 commit into from
May 28, 2022

Conversation

kraity
Copy link
Collaborator

@kraity kraity commented May 28, 2022

What this PR does / why we need it?

kotlin constructor parameter supports default value #370

Summary of your change

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

@kraity kraity changed the title kotlin constructor parameter supports default value # 370 kotlin constructor parameter supports default value #370 May 28, 2022
@wenshao wenshao added this to the 2.0.6 milestone May 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 28, 2022

Codecov Report

Merging #373 (334c4f3) into main (0d1e4b9) will decrease coverage by 0.03%.
The diff coverage is 54.28%.

@@             Coverage Diff              @@
##               main     #373      +/-   ##
============================================
- Coverage     70.26%   70.22%   -0.04%     
+ Complexity    10742    10741       -1     
============================================
  Files           514      514              
  Lines         51559    51554       -5     
  Branches      10776    10779       +3     
============================================
- Hits          36226    36202      -24     
- Misses        10918    10941      +23     
+ Partials       4415     4411       -4     
Impacted Files Coverage Δ
...ain/java/com/alibaba/fastjson2/codec/BeanInfo.java 100.00% <ø> (ø)
...ibaba/fastjson2/writer/ObjectWriterBaseModule.java 81.11% <0.00%> (ø)
.../alibaba/fastjson2/reader/ConstructorFunction.java 77.50% <52.00%> (-13.27%) ⬇️
.../alibaba/fastjson2/reader/ObjectReaderCreator.java 80.83% <60.00%> (-0.18%) ⬇️
...ain/java/com/alibaba/fastjson2/util/BeanUtils.java 61.64% <66.66%> (+0.02%) ⬆️
...ibaba/fastjson2/reader/ObjectReaderBaseModule.java 75.67% <100.00%> (ø)
...java/com/alibaba/fastjson/parser/ParserConfig.java 75.00% <0.00%> (-25.00%) ⬇️
.../alibaba/fastjson2/writer/ObjectWriterCreator.java 67.75% <0.00%> (-2.93%) ⬇️
...main/java/com/alibaba/fastjson/util/TypeUtils.java 8.74% <0.00%> (-1.64%) ⬇️
...src/main/java/com/alibaba/fastjson/JSONObject.java 63.45% <0.00%> (-1.64%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d1e4b9...334c4f3. Read the comment docs.

@wenshao wenshao merged commit 8daf66d into alibaba:main May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants