Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: check LE/BE to use ByteOrder #578

Merged
merged 1 commit into from
Jul 23, 2022
Merged

perf: check LE/BE to use ByteOrder #578

merged 1 commit into from
Jul 23, 2022

Conversation

kraity
Copy link
Collaborator

@kraity kraity commented Jul 23, 2022

What this PR does / why we need it?

check LE/BE to use ByteOrder

Summary of your change

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2022

Codecov Report

Merging #578 (9218295) into main (1039d92) will increase coverage by 0.00%.
The diff coverage is 5.88%.

@@            Coverage Diff            @@
##               main     #578   +/-   ##
=========================================
  Coverage     73.24%   73.24%           
+ Complexity    13248    13245    -3     
=========================================
  Files           587      587           
  Lines         58411    58396   -15     
  Branches      12176    12173    -3     
=========================================
- Hits          42781    42775    -6     
+ Misses        10737    10733    -4     
+ Partials       4893     4888    -5     
Impacted Files Coverage Δ
...in/java/com/alibaba/fastjson2/JSONReaderJSONB.java 70.36% <0.00%> (ø)
...in/java/com/alibaba/fastjson2/JSONWriterJSONB.java 79.78% <0.00%> (ø)
...main/java/com/alibaba/fastjson2/util/JDKUtils.java 72.72% <0.00%> (+3.16%) ⬆️
...ain/java/com/alibaba/fastjson2/util/JSONBDump.java 64.84% <0.00%> (ø)
...n/java/com/alibaba/fastjson2/util/UnsafeUtils.java 71.01% <100.00%> (ø)
...n/java/com/alibaba/fastjson2/JSONWriterPretty.java 100.00% <0.00%> (ø)
...java/com/alibaba/fastjson2/writer/FieldWriter.java 62.93% <0.00%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1039d92...9218295. Read the comment docs.

@wenshao wenshao merged commit 1de2e25 into alibaba:main Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants