Add metric CountMap and Average #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunfengzhou-hub
force-pushed
the
metric-map-list
branch
2 times, most recently
from
7e9ffa7 to
543462f
Compare
Collaborator
Author
|
Hi @Sxnan could you please take a look at this PR? |
Sxnan
reviewed
Sep 15, 2023
Collaborator
Sxnan
left a comment
Sxnan
left a comment
There was a problem hiding this comment.
@yunfengzhou-hub Thanks for the PR! I left some comments below.
...ometheus/src/main/java/com/alibaba/feathub/flink/connectors/prometheus/MapMetricUpdater.java
Outdated
Show resolved
Hide resolved
...ometheus/src/main/java/com/alibaba/feathub/flink/connectors/prometheus/MapMetricUpdater.java
Outdated
Show resolved
Hide resolved
yunfengzhou-hub
force-pushed
the
metric-map-list
branch
2 times, most recently
from
0c5f3f1 to
f03eea9
Compare
Collaborator
Author
|
Thanks for the comments @Sxnan. I have updated the PR according to the comments. |
Collaborator
|
@yunfengzhou-hub Thanks for the update! LGTM. @lindong28 Could you take a look at this PR? |
yunfengzhou-hub
force-pushed
the
metric-map-list
branch
2 times, most recently
from
d07754e to
3fcbb35
Compare
lindong28
reviewed
Sep 18, 2023
Collaborator
lindong28
left a comment
lindong28
left a comment
There was a problem hiding this comment.
Thanks for the PR. Left some comments below.
...us/src/main/java/com/alibaba/feathub/flink/connectors/prometheus/PrometheusSinkFunction.java
Show resolved
Hide resolved
yunfengzhou-hub
force-pushed
the
metric-map-list
branch
3 times, most recently
from
4fcd9a6 to
1aaf733
Compare
yunfengzhou-hub
changed the title
Collaborator
Author
|
Thanks for the comments @lindong28. I have updated the PR according to the comments. |
lindong28
reviewed
Sep 19, 2023
Collaborator
lindong28
left a comment
lindong28
left a comment
There was a problem hiding this comment.
Thanks for the update. Left one comment below.
yunfengzhou-hub
force-pushed
the
metric-map-list
branch
from
1aaf733 to
a94e1d0
Compare
Collaborator
Author
|
Thanks for the comment @lindong28. I have updated PR according to the comment. |
Collaborator
|
Thanks for the update! LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR mainly adds metrics CountMap and Average.
Brief change log
SIZECountMapandAverage.Does this pull request potentially affect one of the following parts:
Documentation