Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): fix x-content is not work with array type #1719

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

janryWang
Copy link
Collaborator

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

Fixed #1718

@codecov
Copy link

codecov bot commented Jul 6, 2021

Codecov Report

Merging #1719 (26d2715) into formily_next (4f4be6a) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           formily_next    #1719      +/-   ##
================================================
- Coverage         91.77%   91.77%   -0.01%     
================================================
  Files               135      135              
  Lines              5994     5993       -1     
  Branches           1496     1495       -1     
================================================
- Hits               5501     5500       -1     
  Misses              489      489              
  Partials              4        4              
Impacted Files Coverage Δ
packages/react/src/components/RecursionField.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f4be6a...26d2715. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2021

Size Change: +5 B (0%)

Total Size: 575 kB

Filename Size Change
packages/react/dist/formily.react.umd.development.js 11.2 kB +5 B (0%)
ℹ️ View Unchanged
Filename Size
designable/antd/dist/formily.designable.antd.umd.development.js 133 kB
designable/antd/dist/formily.designable.antd.umd.production.js 103 kB
designable/next/dist/formily.designable.next.umd.development.js 332 B
designable/next/dist/formily.designable.next.umd.production.js 252 B
designable/setters/dist/formily.designable.antd.umd.development.js 331 B
designable/setters/dist/formily.designable.antd.umd.production.js 251 B
packages/antd/dist/formily.antd.umd.development.js 59.3 kB
packages/antd/dist/formily.antd.umd.production.js 34.1 kB
packages/core/dist/formily.core.umd.development.js 17.9 kB
packages/core/dist/formily.core.umd.production.js 12 kB
packages/json-schema/dist/formily.json-schema.umd.development.js 6.86 kB
packages/json-schema/dist/formily.json-schema.umd.production.js 4.87 kB
packages/next/dist/formily.next.umd.development.js 60.4 kB
packages/next/dist/formily.next.umd.production.js 35.4 kB
packages/path/dist/formily.path.umd.development.js 12 kB
packages/path/dist/formily.path.umd.production.js 8.38 kB
packages/react/dist/formily.react.umd.production.js 6.97 kB
packages/reactive-react/dist/formily.reactive-react.umd.development.js 3.42 kB
packages/reactive-react/dist/formily.reactive-react.umd.production.js 2.25 kB
packages/reactive-vue/dist/formily.reactive-vue.umd.development.js 2.37 kB
packages/reactive-vue/dist/formily.reactive-vue.umd.production.js 1.76 kB
packages/reactive/dist/formily.reactive.umd.development.js 7.65 kB
packages/reactive/dist/formily.reactive.umd.production.js 4.55 kB
packages/shared/dist/formily.shared.umd.development.js 6.35 kB
packages/shared/dist/formily.shared.umd.production.js 4.1 kB
packages/validator/dist/formily.validator.umd.development.js 7.01 kB
packages/validator/dist/formily.validator.umd.production.js 5.61 kB
packages/vue/dist/formily.vue.umd.development.js 14.3 kB
packages/vue/dist/formily.vue.umd.production.js 9.18 kB

compressed-size-action

@janryWang janryWang merged commit 2cd60d3 into formily_next Jul 6, 2021
@janryWang janryWang deleted the fix_x-content_not_work branch July 6, 2021 03:43
janryWang pushed a commit that referenced this pull request Jul 8, 2021
* fix(vue): fix x-content is not work with array type (#1719)

* feat(element): add upload x-content demo with arry type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] x-content 没有识别为 component 的子节点
1 participant