fix(typings): correction FormLayout、Submit typings #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
monkindey
reviewed
Jul 17, 2019
docs/API/Submit.md
Outdated
| [ant-button](https://ant.design/components/button-cn/) | ||
| 继承 [next-button](https://fusion.design/component/basic/button#button) / | ||
| [ant-button](https://ant.design/components/button-cn/#API) | ||
| > 原有组件的 loading 属性会被拓展的 showLoading 属性所替代 |
| > 主要用于控制Submit组件是否自动展示loading图标，要求SchemaForm的onSubmit回调必须返回Promise对象才会生效。 | ||
| | 属性名称 | 属性描述 | 属性类型 | 默认值 | 可选值 | | ||
| | ---- | ---- | ---- | --- | --- | | ||
| | showLoading | 主要用于控制Submit组件是否自动展示loading图标，要求SchemaForm的onSubmit回调必须返回Promise对象才会生效。 | `boolean` | | | |
stkevintan
suggested changes
Jul 18, 2019
There was a problem hiding this comment.
TFormLayout应该是React.FunctionComponent<IFormLayoutProps> 另外createVirtualBox返回的VirtualBox组件的props应该还有name和render属性（都可选）, 目前麻烦手动加一下，以后会用泛型来重构掉。
const VirtualBox = ({ children, name: fieldName, render, ...props }) => (
<SchemaField
type="object"
name={fieldName}
x-component={name}
x-props={props}
x-render={render}
>
{children}
</SchemaField>
)
stkevintan
reviewed
Jul 18, 2019
stkevintan
approved these changes
Jul 18, 2019
ZirkleTsing
pushed a commit
that referenced
this pull request
May 14, 2020
* fix(typings): correction FormLayout、Submit typings * docs(Submit): update API description * refactor: extract typings * docs(Submit): fix mistakes wording * refactor: modify FormLayout typings * refactor: modify FormLayout IFieldProps import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修正
FormLayout、Submit组件的类型声明Close #181