Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ts): map @formily/* to src folder during development #1917

Merged
merged 2 commits into from
Aug 1, 2021

Conversation

zjffun
Copy link
Contributor

@zjffun zjffun commented Jul 31, 2021

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

在开发时让 @formily/* 去找对应的 src 目录,方便开发,和 alibaba/designable#26 做的事一样。

经测试应用这个修改后 build 的代码除了 packages/core/esm/shared/internals.d.ts 其他都没变。具体变化:

export declare const validateToFeedbacks: (field: Field, triggerType?: ValidatorTriggerType) => Promise<import("../../../validator/esm").IValidateResults>;

变为

export declare const validateToFeedbacks: (field: Field, triggerType?: ValidatorTriggerType) => Promise<import("@formily/validator").IValidateResults>;

@codecov
Copy link

codecov bot commented Jul 31, 2021

Codecov Report

Merging #1917 (8621889) into formily_next (48f574e) will increase coverage by 0.24%.
The diff coverage is 95.45%.

Impacted file tree graph

@@               Coverage Diff                @@
##           formily_next    #1917      +/-   ##
================================================
+ Coverage         92.70%   92.94%   +0.24%     
================================================
  Files               136      136              
  Lines              6114     6126      +12     
  Branches           1520     1471      -49     
================================================
+ Hits               5668     5694      +26     
+ Misses              442      428      -14     
  Partials              4        4              
Impacted Files Coverage Δ
packages/core/src/models/Form.ts 99.39% <87.50%> (-0.31%) ⬇️
packages/core/src/models/ArrayField.ts 100.00% <100.00%> (ø)
packages/core/src/models/Field.ts 99.21% <100.00%> (+<0.01%) ⬆️
packages/core/src/models/VoidField.ts 100.00% <100.00%> (ø)
packages/core/src/shared/internals.ts 95.77% <100.00%> (-0.03%) ⬇️
packages/validator/src/rules.ts 100.00% <0.00%> (+1.35%) ⬆️
packages/validator/src/parser.ts 100.00% <0.00%> (+13.55%) ⬆️
packages/validator/src/registry.ts 100.00% <0.00%> (+13.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5fa145...8621889. Read the comment docs.

@janryWang
Copy link
Collaborator

janryWang commented Jul 31, 2021

devtools也是个workspace,应该也得加一下吧

@janryWang janryWang merged commit 65259a0 into alibaba:formily_next Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants