Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(reactive): break change to redefine action semantics #1930

Merged
merged 3 commits into from
Aug 3, 2021

Conversation

janryWang
Copy link
Collaborator

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

reference #1928

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2021

Size Change: +170 B (0%)

Total Size: 1.55 MB

Filename Size Change
packages/antd/dist/formily.antd.umd.development.js 60.6 kB +4 B (0%)
packages/antd/dist/formily.antd.umd.production.js 34.8 kB +5 B (0%)
packages/core/dist/formily.core.umd.development.js 18.3 kB -162 B (-1%)
packages/core/dist/formily.core.umd.production.js 12.3 kB -119 B (-1%)
packages/element/dist/formily.element.umd.development.js 53.1 kB +5 B (0%)
packages/element/dist/formily.element.umd.production.js 30.5 kB +4 B (0%)
packages/next/dist/formily.next.umd.development.js 62 kB +175 B (0%)
packages/next/dist/formily.next.umd.production.js 36.3 kB +82 B (0%)
packages/reactive/dist/formily.reactive.umd.development.js 8.32 kB +108 B (+1%)
packages/reactive/dist/formily.reactive.umd.production.js 4.97 kB +68 B (+1%)
ℹ️ View Unchanged
Filename Size
designable/antd/dist/formily.designable.antd.umd.development.js 348 kB
designable/antd/dist/formily.designable.antd.umd.production.js 235 kB
designable/next/dist/formily.designable.next.umd.development.js 332 B
designable/next/dist/formily.designable.next.umd.production.js 252 B
designable/setters/dist/formily.designable.antd.umd.development.js 323 kB
designable/setters/dist/formily.designable.antd.umd.production.js 216 kB
packages/json-schema/dist/formily.json-schema.umd.development.js 7.09 kB
packages/json-schema/dist/formily.json-schema.umd.production.js 5 kB
packages/path/dist/formily.path.umd.development.js 12 kB
packages/path/dist/formily.path.umd.production.js 8.4 kB
packages/react/dist/formily.react.umd.development.js 11.4 kB
packages/react/dist/formily.react.umd.production.js 7.11 kB
packages/reactive-react/dist/formily.reactive-react.umd.development.js 3.43 kB
packages/reactive-react/dist/formily.reactive-react.umd.production.js 2.26 kB
packages/reactive-vue/dist/formily.reactive-vue.umd.development.js 2.37 kB
packages/reactive-vue/dist/formily.reactive-vue.umd.production.js 1.76 kB
packages/shared/dist/formily.shared.umd.development.js 6.49 kB
packages/shared/dist/formily.shared.umd.production.js 4.18 kB
packages/validator/dist/formily.validator.umd.development.js 7.11 kB
packages/validator/dist/formily.validator.umd.production.js 5.66 kB
packages/vue/dist/formily.vue.umd.development.js 14.7 kB
packages/vue/dist/formily.vue.umd.production.js 9.32 kB

compressed-size-action

@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #1930 (06cb7a6) into formily_next (48f574e) will increase coverage by 0.33%.
The diff coverage is 98.52%.

Impacted file tree graph

@@               Coverage Diff                @@
##           formily_next    #1930      +/-   ##
================================================
+ Coverage         92.70%   93.04%   +0.33%     
================================================
  Files               136      137       +1     
  Lines              6114     6136      +22     
  Branches           1520     1467      -53     
================================================
+ Hits               5668     5709      +41     
+ Misses              442      423      -19     
  Partials              4        4              
Impacted Files Coverage Δ
packages/reactive/src/types.ts 100.00% <ø> (ø)
packages/validator/src/rules.ts 100.00% <ø> (+1.35%) ⬆️
packages/validator/src/types.ts 100.00% <ø> (ø)
packages/core/src/models/Form.ts 99.38% <90.00%> (-0.32%) ⬇️
packages/core/src/models/ArrayField.ts 100.00% <100.00%> (ø)
packages/core/src/models/Field.ts 99.21% <100.00%> (+<0.01%) ⬆️
packages/core/src/models/ObjectField.ts 100.00% <100.00%> (ø)
packages/core/src/models/VoidField.ts 100.00% <100.00%> (ø)
packages/core/src/shared/internals.ts 95.77% <100.00%> (-0.03%) ⬇️
packages/reactive/src/action.ts 100.00% <100.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 799f422...06cb7a6. Read the comment docs.

@janryWang janryWang merged commit 1b0a753 into formily_next Aug 3, 2021
@janryWang janryWang deleted the support_batch_untracked_api branch August 3, 2021 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant