Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix array unshift with incomplete elements #2150

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

janryWang
Copy link
Collaborator

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

Fixed #2147

@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #2150 (1ba6091) into formily_next (48f574e) will increase coverage by 0.72%.
The diff coverage is 98.29%.

Impacted file tree graph

@@               Coverage Diff                @@
##           formily_next    #2150      +/-   ##
================================================
+ Coverage         92.70%   93.43%   +0.72%     
================================================
  Files               136      137       +1     
  Lines              6114     6153      +39     
  Branches           1520     1530      +10     
================================================
+ Hits               5668     5749      +81     
+ Misses              442      400      -42     
  Partials              4        4              
Impacted Files Coverage Δ
packages/core/src/types.ts 100.00% <ø> (ø)
packages/core/src/models/Form.ts 99.38% <90.00%> (-0.32%) ⬇️
packages/core/src/models/ArrayField.ts 100.00% <100.00%> (ø)
packages/core/src/models/Field.ts 99.21% <100.00%> (+<0.01%) ⬆️
packages/core/src/models/Heart.ts 100.00% <100.00%> (ø)
packages/core/src/models/ObjectField.ts 100.00% <100.00%> (ø)
packages/core/src/models/VoidField.ts 100.00% <100.00%> (ø)
packages/core/src/shared/constants.ts 100.00% <100.00%> (ø)
packages/core/src/shared/internals.ts 100.00% <100.00%> (+4.20%) ⬆️
packages/path/src/parser.ts 92.68% <0.00%> (-0.35%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48ed7b0...1ba6091. Read the comment docs.

@github-actions
Copy link
Contributor

Size Change: +149 B (0%)

Total Size: 438 kB

Filename Size Change
packages/antd/dist/formily.antd.umd.development.js 61.3 kB +4 B (0%)
packages/core/dist/formily.core.umd.development.js 18.8 kB +102 B (+1%)
packages/core/dist/formily.core.umd.production.js 12.4 kB +43 B (0%)
ℹ️ View Unchanged
Filename Size
packages/antd/dist/formily.antd.umd.production.js 34.9 kB
packages/element/dist/formily.element.umd.development.js 55.1 kB
packages/element/dist/formily.element.umd.production.js 31.5 kB
packages/json-schema/dist/formily.json-schema.umd.development.js 7.07 kB
packages/json-schema/dist/formily.json-schema.umd.production.js 4.49 kB
packages/next/dist/formily.next.umd.development.js 62.9 kB
packages/next/dist/formily.next.umd.production.js 36.6 kB
packages/path/dist/formily.path.umd.development.js 13.1 kB
packages/path/dist/formily.path.umd.production.js 8.4 kB
packages/react/dist/formily.react.umd.development.js 11.3 kB
packages/react/dist/formily.react.umd.production.js 7.07 kB
packages/reactive-react/dist/formily.reactive-react.umd.development.js 3.61 kB
packages/reactive-react/dist/formily.reactive-react.umd.production.js 2.26 kB
packages/reactive-vue/dist/formily.reactive-vue.umd.development.js 2.83 kB
packages/reactive-vue/dist/formily.reactive-vue.umd.production.js 1.8 kB
packages/reactive/dist/formily.reactive.umd.development.js 8.68 kB
packages/reactive/dist/formily.reactive.umd.production.js 4.98 kB
packages/shared/dist/formily.shared.umd.development.js 7.38 kB
packages/shared/dist/formily.shared.umd.production.js 4.19 kB
packages/validator/dist/formily.validator.umd.development.js 7.58 kB
packages/validator/dist/formily.validator.umd.production.js 5.66 kB
packages/vue/dist/formily.vue.umd.development.js 14.9 kB
packages/vue/dist/formily.vue.umd.production.js 9.36 kB

compressed-size-action

@janryWang janryWang merged commit 6463371 into formily_next Sep 13, 2021
@janryWang janryWang deleted the fix_array_unshift branch September 13, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] ArrayTable以unshift方式新增时,页面显示与实际数据不符
1 participant