Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(antd/next): improve FormItem render performance #2237

Merged
merged 9 commits into from
Sep 25, 2021

Conversation

janryWang
Copy link
Collaborator

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #2237 (c1779fe) into formily_next (2392888) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           formily_next    #2237      +/-   ##
================================================
- Coverage         95.38%   95.35%   -0.03%     
================================================
  Files               138      137       -1     
  Lines              6170     6185      +15     
  Branches           1555     1557       +2     
================================================
+ Hits               5885     5898      +13     
- Misses              280      282       +2     
  Partials              5        5              
Impacted Files Coverage Δ
packages/json-schema/src/compiler.ts 100.00% <ø> (ø)
packages/reactive/src/types.ts 100.00% <ø> (ø)
packages/core/src/models/Field.ts 99.12% <100.00%> (-0.02%) ⬇️
packages/core/src/models/Form.ts 100.00% <100.00%> (ø)
packages/core/src/models/VoidField.ts 100.00% <100.00%> (ø)
packages/core/src/shared/internals.ts 99.81% <100.00%> (+<0.01%) ⬆️
packages/json-schema/src/schema.ts 100.00% <100.00%> (ø)
packages/json-schema/src/shared.ts 100.00% <100.00%> (ø)
packages/reactive/src/array.ts 100.00% <100.00%> (ø)
packages/reactive/src/datatree.ts 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7e70b9...c1779fe. Read the comment docs.

@github-actions
Copy link
Contributor

Size Change: +19 B (0%)

Total Size: 437 kB

Filename Size Change
packages/antd/dist/formily.antd.umd.development.js 61.4 kB +7 B (0%)
packages/antd/dist/formily.antd.umd.production.js 34.9 kB +6 B (0%)
packages/next/dist/formily.next.umd.production.js 36.6 kB +6 B (0%)
ℹ️ View Unchanged
Filename Size
packages/core/dist/formily.core.umd.development.js 19.3 kB
packages/core/dist/formily.core.umd.production.js 12.9 kB
packages/element/dist/formily.element.umd.development.js 55.2 kB
packages/element/dist/formily.element.umd.production.js 31.5 kB
packages/json-schema/dist/formily.json-schema.umd.development.js 6.79 kB
packages/json-schema/dist/formily.json-schema.umd.production.js 4.24 kB
packages/next/dist/formily.next.umd.development.js 62.9 kB
packages/path/dist/formily.path.umd.development.js 11 kB
packages/path/dist/formily.path.umd.production.js 7.62 kB
packages/react/dist/formily.react.umd.development.js 11.1 kB
packages/react/dist/formily.react.umd.production.js 6.87 kB
packages/reactive-react/dist/formily.reactive-react.umd.development.js 3.61 kB
packages/reactive-react/dist/formily.reactive-react.umd.production.js 2.26 kB
packages/reactive-vue/dist/formily.reactive-vue.umd.development.js 2.83 kB
packages/reactive-vue/dist/formily.reactive-vue.umd.production.js 1.8 kB
packages/reactive/dist/formily.reactive.umd.development.js 8.81 kB
packages/reactive/dist/formily.reactive.umd.production.js 5.08 kB
packages/shared/dist/formily.shared.umd.development.js 7.38 kB
packages/shared/dist/formily.shared.umd.production.js 4.19 kB
packages/validator/dist/formily.validator.umd.development.js 8.24 kB
packages/validator/dist/formily.validator.umd.production.js 6.15 kB
packages/vue/dist/formily.vue.umd.development.js 15 kB
packages/vue/dist/formily.vue.umd.production.js 9.22 kB

compressed-size-action

@janryWang janryWang merged commit 64445d0 into formily_next Sep 25, 2021
@janryWang janryWang deleted the perf_form_item branch September 25, 2021 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant