Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reactive): fix reaction force untrack will effect to setState #2278

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

janryWang
Copy link
Collaborator

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #2278 (7fd7bc5) into formily_next (9ed17eb) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           formily_next    #2278      +/-   ##
================================================
- Coverage         95.29%   95.29%   -0.01%     
================================================
  Files               138      138              
  Lines              6099     6098       -1     
  Branches           1538     1538              
================================================
- Hits               5812     5811       -1     
  Misses              282      282              
  Partials              5        5              
Impacted Files Coverage Δ
packages/reactive/src/autorun.ts 100.00% <100.00%> (ø)
packages/validator/src/registry.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ed17eb...7fd7bc5. Read the comment docs.

@github-actions
Copy link
Contributor

Size Change: -31 B (0%)

Total Size: 437 kB

Filename Size Change
packages/reactive/dist/formily.reactive.umd.development.js 8.87 kB -25 B (0%)
packages/reactive/dist/formily.reactive.umd.production.js 5.13 kB -6 B (0%)
ℹ️ View Unchanged
Filename Size
packages/antd/dist/formily.antd.umd.development.js 61.4 kB
packages/antd/dist/formily.antd.umd.production.js 34.9 kB
packages/core/dist/formily.core.umd.development.js 18.9 kB
packages/core/dist/formily.core.umd.production.js 12.8 kB
packages/element/dist/formily.element.umd.development.js 55 kB
packages/element/dist/formily.element.umd.production.js 31.4 kB
packages/json-schema/dist/formily.json-schema.umd.development.js 6.84 kB
packages/json-schema/dist/formily.json-schema.umd.production.js 4.3 kB
packages/next/dist/formily.next.umd.development.js 62.9 kB
packages/next/dist/formily.next.umd.production.js 36.7 kB
packages/path/dist/formily.path.umd.development.js 11 kB
packages/path/dist/formily.path.umd.production.js 7.64 kB
packages/react/dist/formily.react.umd.development.js 11.2 kB
packages/react/dist/formily.react.umd.production.js 6.93 kB
packages/reactive-react/dist/formily.reactive-react.umd.development.js 3.61 kB
packages/reactive-react/dist/formily.reactive-react.umd.production.js 2.26 kB
packages/reactive-vue/dist/formily.reactive-vue.umd.development.js 2.83 kB
packages/reactive-vue/dist/formily.reactive-vue.umd.production.js 1.8 kB
packages/shared/dist/formily.shared.umd.development.js 7.38 kB
packages/shared/dist/formily.shared.umd.production.js 4.19 kB
packages/validator/dist/formily.validator.umd.development.js 8.3 kB
packages/validator/dist/formily.validator.umd.production.js 6.18 kB
packages/vue/dist/formily.vue.umd.development.js 15.1 kB
packages/vue/dist/formily.vue.umd.production.js 9.29 kB

compressed-size-action

@janryWang janryWang merged commit 17b9315 into formily_next Oct 11, 2021
@janryWang janryWang deleted the fix_reaction_force_untrack branch October 11, 2021 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant