fix(core): make exchangeArrayState be right when move #2357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
janryWang
reviewed
Oct 27, 2021
| @@ -411,8 +411,9 @@ test('array field move api with children', async () => { | |||
| }) | |||
| ) | |||
| await array.move(0, 2) | |||
| expect(form.fields['array.0.name']).not.toBeUndefined() | |||
There was a problem hiding this comment.
这个单元测试是之前的 交换 的逻辑，实际应该验证的逻辑是现在的，插入后再移动
There was a problem hiding this comment.
0 -> 2，原先是 0, 1, 2(name)，就变成 1, 2(name), 0，所以测试应该是 0 和 2 位没有，1 位有
Codecov Report
@@ Coverage Diff @@
## formily_next #2357 +/- ##
=============================================
Coverage 95.31% 95.31%
=============================================
Files 140 140
Lines 6120 6129 +9
Branches 1543 1547 +4
=============================================
+ Hits 5833 5842 +9
Misses 282 282
Partials 5 5
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please make sure the following is done...
masterorformily_next.npm test).npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.Please do not delete the above content
What have you changed?
#2355