Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(reactive-vue): fix vue3 render dependency collection broken #2904

Merged
merged 1 commit into from
Mar 5, 2022
Merged

fix(reactive-vue): fix vue3 render dependency collection broken #2904

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 22 additions & 13 deletions packages/reactive-vue/src/hooks/useObserver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,25 +16,34 @@ export const useObserver = (options?: IObserverOptions) => {

onBeforeUnmount(disposeTracker)

Object.defineProperty(vm, 'update', {
Object.defineProperty(vm, 'effect', {
get() {
// https://github.com/alibaba/formily/issues/2655
return vm['_updateEffect'] || {}
},
set(newValue) {
disposeTracker()
vm['_updateEffectRun'] = newValue.run
const newTracker = () => {
disposeTracker()
tracker = new Tracker(() => {
if (options?.scheduler && typeof options.scheduler === 'function') {
options.scheduler(update)
} else {
update()
}
})
}
const update = function () {
newTracker()
let refn: any = null
tracker?.track(() => {
refn = vm['_updateEffectRun'].call(newValue)
})
return refn
}

const update = () => tracker?.track(newValue)

tracker = new Tracker(() => {
if (options?.scheduler && typeof options.scheduler === 'function') {
options.scheduler(update)
} else {
update()
}
})

vm['_updateEffect'] = update
newValue.run = update
vm['_updateEffect'] = newValue
},
})
}
Expand Down