Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix field destroyed still can be assigned value #3115

Merged

Conversation

janryWang
Copy link
Collaborator

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

Fixed #3109

@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #3115 (d4ebffd) into formily_next (7d731af) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##           formily_next    #3115   +/-   ##
=============================================
  Coverage         96.08%   96.08%           
=============================================
  Files               149      149           
  Lines              6518     6520    +2     
  Branches           1812     1815    +3     
=============================================
+ Hits               6263     6265    +2     
  Misses              225      225           
  Partials             30       30           
Impacted Files Coverage Δ
packages/core/src/models/Field.ts 98.57% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d731af...d4ebffd. Read the comment docs.

@github-actions
Copy link
Contributor

Size Change: +14 B (0%)

Total Size: 507 kB

Filename Size Change
packages/core/dist/formily.core.umd.development.js 19.9 kB +2 B (0%)
packages/core/dist/formily.core.umd.production.js 13.4 kB +12 B (0%)
ℹ️ View Unchanged
Filename Size
packages/antd/dist/formily.antd.umd.development.js 71.8 kB
packages/antd/dist/formily.antd.umd.production.js 40.1 kB
packages/element/dist/formily.element.umd.development.js 62.7 kB
packages/element/dist/formily.element.umd.production.js 36.4 kB
packages/grid/dist/formily.grid.umd.development.js 9.01 kB
packages/grid/dist/formily.grid.umd.production.js 6.07 kB
packages/json-schema/dist/formily.json-schema.umd.development.js 6.88 kB
packages/json-schema/dist/formily.json-schema.umd.production.js 4.36 kB
packages/next/dist/formily.next.umd.development.js 76.8 kB
packages/next/dist/formily.next.umd.production.js 44.7 kB
packages/path/dist/formily.path.umd.development.js 11.2 kB
packages/path/dist/formily.path.umd.production.js 7.72 kB
packages/react/dist/formily.react.umd.development.js 11.5 kB
packages/react/dist/formily.react.umd.production.js 7.11 kB
packages/reactive-react/dist/formily.reactive-react.umd.development.js 3.61 kB
packages/reactive-react/dist/formily.reactive-react.umd.production.js 2.25 kB
packages/reactive-vue/dist/formily.reactive-vue.umd.development.js 2.96 kB
packages/reactive-vue/dist/formily.reactive-vue.umd.production.js 1.87 kB
packages/reactive/dist/formily.reactive.umd.development.js 9.32 kB
packages/reactive/dist/formily.reactive.umd.production.js 5.22 kB
packages/shared/dist/formily.shared.umd.development.js 7.22 kB
packages/shared/dist/formily.shared.umd.production.js 4.18 kB
packages/validator/dist/formily.validator.umd.development.js 8.43 kB
packages/validator/dist/formily.validator.umd.production.js 6.28 kB
packages/vue/dist/formily.vue.umd.development.js 16.4 kB
packages/vue/dist/formily.vue.umd.production.js 9.79 kB

compressed-size-action

@janryWang janryWang merged commit 5dd9acc into formily_next May 11, 2022
@janryWang janryWang deleted the fix_field_destroyed_still_can_be_assigned_value branch May 11, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] An array field does not reset properly because of a reactive display change
1 participant