Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue): fix reactions not work correctly in schema field #3287

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

MisicDemone
Copy link
Collaborator

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


该PR影响的场景,当SchemaField作为某组件子元素时,外层会比之前多一个 display:contents 的 div 元素(替换了原本产生问题的Fragment组件),对于某些会检测子元素个数的父组件会有影响。例如:

<FormProvider :form="form">
  <FormGrid>
    <SchemaField :schema="schema" />
    <OtherFields />
  </FormGrid>
</FormProvider>

FormGrid 会根据子元素个数给定不同的默认值,在以上场景,手动设置 minColumns 等属性可保证前后表现一致。

@MisicDemone
Copy link
Collaborator Author

关联issue:#3262

@janryWang janryWang merged commit 551ad0f into alibaba:formily_next Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants