Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix setValues/setInitialValues will change ref #3529

Merged

Conversation

janryWang
Copy link
Collaborator

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

Fixed #3505

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2022

Size Change: +7 B (0%)

Total Size: 550 kB

Filename Size Change
packages/core/dist/formily.core.umd.development.js 20.1 kB +1 B (0%)
packages/core/dist/formily.core.umd.production.js 13.5 kB +6 B (0%)
ℹ️ View Unchanged
Filename Size
packages/antd/dist/formily.antd.umd.development.js 73.7 kB
packages/antd/dist/formily.antd.umd.production.js 41.2 kB
packages/element/dist/formily.element.umd.development.js 76 kB
packages/element/dist/formily.element.umd.production.js 42.8 kB
packages/grid/dist/formily.grid.umd.development.js 9.01 kB
packages/grid/dist/formily.grid.umd.production.js 6.07 kB
packages/json-schema/dist/formily.json-schema.umd.development.js 6.96 kB
packages/json-schema/dist/formily.json-schema.umd.production.js 4.43 kB
packages/next/dist/formily.next.umd.development.js 78.5 kB
packages/next/dist/formily.next.umd.production.js 45.5 kB
packages/path/dist/formily.path.umd.development.js 11.1 kB
packages/path/dist/formily.path.umd.production.js 7.71 kB
packages/react/dist/formily.react.umd.development.js 6.17 kB
packages/react/dist/formily.react.umd.production.js 3.69 kB
packages/reactive-react/dist/formily.reactive-react.umd.development.js 4.16 kB
packages/reactive-react/dist/formily.reactive-react.umd.production.js 2.46 kB
packages/reactive-vue/dist/formily.reactive-vue.umd.development.js 11.8 kB
packages/reactive-vue/dist/formily.reactive-vue.umd.production.js 6.06 kB
packages/reactive/dist/formily.reactive.umd.development.js 9.52 kB
packages/reactive/dist/formily.reactive.umd.production.js 5.36 kB
packages/shared/dist/formily.shared.umd.development.js 7.42 kB
packages/shared/dist/formily.shared.umd.production.js 4.3 kB
packages/validator/dist/formily.validator.umd.development.js 8.44 kB
packages/validator/dist/formily.validator.umd.production.js 6.28 kB
packages/vue/dist/formily.vue.umd.development.js 24.5 kB
packages/vue/dist/formily.vue.umd.production.js 13.3 kB

compressed-size-action

@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Base: 96.36% // Head: 96.36% // No change to project coverage 👍

Coverage data is based on head (96297cc) compared to base (6e1c604).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##           formily_next    #3529   +/-   ##
=============================================
  Coverage         96.36%   96.36%           
=============================================
  Files               152      152           
  Lines              6595     6595           
  Branches           1778     1778           
=============================================
  Hits               6355     6355           
  Misses              240      240           
Impacted Files Coverage Δ
packages/core/src/models/Form.ts 99.27% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@janryWang janryWang merged commit 886144f into formily_next Nov 9, 2022
@janryWang janryWang deleted the fix_setValues_setInitialValues_with_assign_mode branch November 9, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] 当setValues 和 onFieldValueChange 一块使用时会爆栈
1 participant