feat(core): add model unit test #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
quirkyshop
commented
Nov 1, 2019
quirkyshop
commented
- 增加model单测
- 修复model dirty check比较方法
- 增加model processing 初始值（置false流程未完成，TODO）
- 修复hasChangedInSequence对于 { [x]: false } 仍然报错的问题
- 修复unsafe_setSourceState 无法处理 product(state, (draft) => draft.a = 1))的写法，仿造setState修复
quirkyshop
commented
Nov 1, 2019
| } | ||
|
|
||
| each(draftKeys.length > stateKeys.length ? draft : this.state, (value, key) => { | ||
| if (!isEqual(this.state[key], draft[key])) { |
There was a problem hiding this comment.
eg. draft: { a: 1 } state { }
避免each时value永远是draft[key]
quirkyshop
commented
Nov 1, 2019
| @@ -193,7 +195,7 @@ export const createStateModel = <State = {}, Props = {}>( | |||
| hasChangedInSequence = (key?: string) => | |||
| key | |||
| ? this.persistDirtys[key] | |||
| : Object.keys(this.persistDirtys || {}).length > 0 | |||
| : Object.keys(this.persistDirtys || {}).filter(k => this.persistDirtys[k] === true).length > 0 | |||
There was a problem hiding this comment.
processFlag 变成 processCout 会更合理些，鉴于这个值会超过1，flag命名大多用来表示boolean
ZirkleTsing
pushed a commit
that referenced
this pull request
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.