Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 frontend-grayurl 解析不正确导致路由失败 #1550

Merged
merged 4 commits into from
Nov 29, 2024
Merged

fix: 🐛 frontend-grayurl 解析不正确导致路由失败 #1550

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6a93ef5
fix: 🐛 frontend-gray 页面url解析不正确导致路由失败
heimanba Nov 28, 2024
e45337b
chore: 🤖 添加错误日志
heimanba Nov 28, 2024
916805a
chore: 🤖 add failed path
heimanba Nov 29, 2024
c323733
Merge branch 'main' into main
CH3CHO Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions plugins/wasm-go/extensions/frontend-gray/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package main
import (
"fmt"
"net/http"
"net/url"
"path"
"strings"

Expand Down Expand Up @@ -35,6 +36,10 @@ func parseConfig(json gjson.Result, grayConfig *config.GrayConfig, log wrapper.L
func onHttpRequestHeaders(ctx wrapper.HttpContext, grayConfig config.GrayConfig, log wrapper.Log) types.Action {
requestPath, _ := proxywasm.GetHttpRequestHeader(":path")
requestPath = path.Clean(requestPath)
parsedURL, err := url.Parse(requestPath)
if err == nil {
requestPath = parsedURL.Path
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果有错误的话，是不是应该记录个日志以便排查？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果有错误的话，是不是应该记录个日志以便排查？

done

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是不是把解析失败的path也打出来？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是不是把解析失败的path也打出来？

好的，已经修改

}
enabledGray := util.IsGrayEnabled(grayConfig, requestPath)
ctx.SetContext(config.EnabledGray, enabledGray)

Expand Down
Loading