-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AI proxy return unified status in header phase #1588
Conversation
should we just return |
Returning only "ActionContinue" is okay, as this leaves the handling of the response to the backend service. |
ok, i think it is ready for review. |
It seems that all providers no longer need to worry about the return value of the status code. Can we uniformly adjust the interfaces of all providers? |
emm, yeah, i will adjust the |
build docker image: higress-registry.cn-hangzhou.cr.aliyuncs.com/plugins/wasm-go-builder:go1.20.14-tinygo0.29.0-oras1.0.0 should the build image update? @johnlanni |
Is your PC an ARM architecture? This image likely does not support ARM architecture |
my environment is just x86 |
it can work now, but i have no idea why 😆 , anyway, i can compile now, thanks. |
2ff427d
to
1f5afff
Compare
@johnlanni PTAL, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1588 +/- ##
==========================================
+ Coverage 35.91% 43.42% +7.51%
==========================================
Files 69 76 +7
Lines 11576 12325 +749
==========================================
+ Hits 4157 5352 +1195
+ Misses 7104 6636 -468
- Partials 315 337 +22 |
1f5afff
to
2a22b03
Compare
i have rebased the main branch |
Ⅰ. Describe what this PR did
AI proxy return unified status in header phase.
#1584 (comment)