Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: changlog for 3.4.3 #2970

Merged
merged 2 commits into from
Dec 13, 2019
Merged

chore: changlog for 3.4.3 #2970

merged 2 commits into from
Dec 13, 2019

Conversation

alvinhui
Copy link
Collaborator

No description provided.

@codecov-io
Copy link

codecov-io commented Dec 13, 2019

Codecov Report

Merging #2970 into iceworks/3.4.3 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           iceworks/3.4.3    #2970   +/-   ##
===============================================
  Coverage           65.54%   65.54%           
===============================================
  Files                  20       20           
  Lines                 859      859           
  Branches               47       47           
===============================================
  Hits                  563      563           
  Misses                283      283           
  Partials               13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd93156...8a28e30. Read the comment docs.

@alvinhui alvinhui requested a review from imsobear December 13, 2019 02:10
@alvinhui alvinhui self-assigned this Dec 13, 2019
@alvinhui alvinhui requested a review from ClarkXia December 13, 2019 02:13
CHANGELOG.md Outdated
- [feat] Add client version
- [fix] Aet default value for projects
- [fix] Environment variable PATH is empty
- [refactor]: Using CND QR Code
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

统一没冒号吧

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯,所有都是没有冒号的

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@ClarkXia ClarkXia merged commit 1667196 into iceworks/3.4.3 Dec 13, 2019
@delete-merged-branch delete-merged-branch bot deleted the iceworks/changelog branch December 13, 2019 02:24
chenbin92 pushed a commit that referenced this pull request Jan 3, 2020
* chore: new version for iceworks-client

* chore: new version for iceworks-cli

* feat: add client version (#2932)

* feat: add asset version

* chore: lint

* chore: new  test for home.html

* fix: set default value for projects (#2937)

* fix: shell path (#2964)

* fix: shell path

* fix: make sure process.env.PATH is string

* chore: using CND qrcode (#2967)

* chore: changlog for 3.4.3 (#2970)

* feat: changlog

* chore: typo

* chore: typo

Co-authored-by: 大果 <sobear.me@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants