feat: support route wrappers #3189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenbin92
commented
May 11, 2020
| let mergedRouteWrappers = routeWrappers; | ||
| if (route.wrappers && route.wrappers.length) { | ||
| mergedRouteWrappers = routeWrappers.concat(route.wrappers); | ||
| } |
There was a problem hiding this comment.
验证 pageConfig 的功能
@imsobear 这里只是收集 wrappers 阶段，最后会在这里统一挂载 pageConfig
|
@ClarkXia 「约定式」和「配置式」都支持了 wrappers 属性，统一通过 pageConfig 进行配置： HomePage.pageConfig = {
// 支持多个
wrappers: [],
} |
ClarkXia
reviewed
May 11, 2020
| title: 'Dashboard Page', | ||
| wrappers: [wrapperPage] | ||
| }; | ||
|
|
||
| export default Dashboard; |
There was a problem hiding this comment.
跟这种方式 export default wrapperPage(Dashboard) 对比，唯一的优势就是不需要处理 pageConfig
结论
|
ClarkXia
requested changes
May 12, 2020
| @@ -39,9 +39,13 @@ function getRouteComponent(component, routerWrappers?: IRouteWrapper[]) { | |||
| function parseRoutes(routes: RouteItemProps[]) { | |||
| return routes.map((route) => { | |||
| const { children, component, routeWrappers, ...others } = route; | |||
| let mergedRouteWrappers = routeWrappers; | |||
| if (route.wrappers && route.wrappers.length) { | |||
There was a problem hiding this comment.
wrappers 跟 routeWrappers 类似应该没必要透传下去了，目前 others 中还包含这项内容？
ClarkXia
approved these changes
May 12, 2020
chenbin92
pushed a commit
that referenced
this pull request
May 14, 2020
* fix: compatible with the index page * fix: create histroy when render root app * feat: support promise function with useRequest (#3188) * fix: repository url (#3192) * feat: optimize webpackbar (#3187) * feat: optimize webpackbar * fix: rename eslintLoaderOptions to eslint * fix: upgrate react-dev-utils (#3190) * fix: upgrate react-dev-utils * v1.2.2-alpha.1 * fix: set transportMode to ws Co-authored-by: ClarkXia <xiawenwu41@gmail.com> * feat: support route wrappers (#3189) * feat: support route wrappers * feat: support pageConfig wrappers * refactor: wrappers api * docs: add wrappers api to ruotes * fix: destructuring routes * feat: enhance use request types (#3195) * feat: enhance useRequest types * chore: remove comments * docs: useRequest usage * v1.2.2-alpha.2 * docs: add withFullResponse api * docs: refactor request docs * chore: typo * chore: useRequest docs * docs: fix typo * docs: optimize title * v1.2.2-alpha.3 * Fix/release bugs (#3205) * fix: types & log * v1.2.2-alpha.4 * fix: no match single page file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.