Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix compile dependencies path in windows #3289

Merged
merged 1 commit into from
Jun 22, 2020

Conversation

luhc228
Copy link
Collaborator

@luhc228 luhc228 commented Jun 22, 2020

修复在 win32 系统 下配置 compileDependencies 字段后,找不到对应的依赖的路径

@luhc228 luhc228 requested a review from ClarkXia June 22, 2020 04:43
@luhc228 luhc228 self-assigned this Jun 22, 2020
@CLAassistant
Copy link

CLAassistant commented Jun 22, 2020

CLA assistant check
All committers have signed the CLA.

@@ -7,7 +7,7 @@ module.exports = (config, compileDependencies) => {
} else if (typeof dep === 'string') {
// add default node_modules
const matchStr = `node_modules/?.+${dep}/`;
return process.platform === 'win32' ? matchStr.replace(/\\/g, '\\\\') : matchStr;
return process.platform === 'win32' ? matchStr.replace(/\//g, '\\\\') : matchStr;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以调用 applyMethod('formatPath', <yourPath>)

@ClarkXia ClarkXia merged commit e0d9acc into release-next Jun 22, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix/compile-deps-path-in-windows branch June 22, 2020 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants