Fix: compatible with page name with - in store #3824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SoloJiang
approved these changes
Nov 16, 2020
ClarkXia
approved these changes
Nov 18, 2020
delete-merged-branch
bot
deleted the
fix/component-name-with--in-store-config
branch
ClarkXia
added a commit
that referenced
this pull request
Nov 23, 2020
* feat: support uniqueName of plugin-icestark (#3804) * feat: support uniqueName of plugin-icestark * chore: version * fix: update userconfig * fix: ci error * chore: optimize code * fix: update userconfig (#3829) * fix: update userconfig * fix: ci error * chore: optimize code * fix: component name with dash code in store config (#3824) * fix: returns html with UNICODE when Chinese words are passed in ssr (#3819) * fix: ssr html decode error * fix: ssr html decode error * fix: cheerio decodeEntities config * fix: package version * fix: typo mpa (#3826) * chore: formate yml * fix: compatible with undefined options (#3828) * fix: compatible with undefined options * chore: version * feat: inner plugin ice auth (#3805) * feat: inner build-plugin-ice-auth * feat: compatible with adding plugin * fix: comment * refactor: mpa config (#3825) * refactor: remove inline loader of entry * fix: format path in win * fix: mpa entries * fix: mpa config * fix: default src dir when use mpa * fix: compatible with files do not export component * feat: support wrappers of Layout component (#3822) * feat: support wrappers of Layout * fix: wrapper router * chore: remove useless code * refactor: motify userconfig * chore: revert minify file * chore: optimize code * feat: support off eslint * feat: support framework custom cli options (#3838) * feat: support framework custom cli options * chore: rename config * feat: update review * fix: compatible with build-mpa-config * fix: default config output dir (#3847) * fix: same instance of task config (#3848) * feat: ssr fallback (#3837) * feat: support ssr fallback * feat: support csr get ctx * chore: getInitialContext func * fix: location undefined * chore: remove package.json * chore: remove useless code * fix: format * fix: state * fix: comment * fix: lint warning * fix: lint warning * fix: ci * docs: update notice of wrappers (#3849) * chore: version (#3834) * chore: version * chore: plugin-mpa version * chore: versions * chore: plugin-store version * chore: version * chore: version Co-authored-by: fushen <fushen.jzw@alibaba-inc.com> Co-authored-by: Hengchang Lu <44047106+luhc228@users.noreply.github.com> Co-authored-by: William <wiolem@hotmail.com> Co-authored-by: yangfan <18767120422@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
问题：
当组件名是连字符（带 - ）的时候，组件命名会有问题，比如：