Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: react-router-dom types not found #4216

Merged
merged 5 commits into from
Apr 15, 2021
Merged

Fix: react-router-dom types not found #4216

merged 5 commits into from
Apr 15, 2021

Conversation

luhc228
Copy link
Collaborator

@luhc228 luhc228 commented Apr 12, 2021

问题

IRouterConfig 类型依赖到 @types/react-router-dom 包中的类型，但当前 plugin-router 中 @types/react-router-dom 是在 devDeps，安装 ice.js 依赖时没有安装该依赖到项目中，导致下面的报错：

image
image

@luhc228 luhc228 changed the title Fix: react-router-dom type Fix: react-router-dom types not found Apr 12, 2021
SoloJiang
SoloJiang approved these changes Apr 15, 2021
View reviewed changes
Copy link
Collaborator

@SoloJiang SoloJiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMG_0156

@luhc228 luhc228 merged commit 4e6a4a2 into release-next Apr 15, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix/react-router-dom-type branch April 15, 2021 03:18
@luhc228 luhc228 mentioned this pull request Apr 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoloJiang SoloJiang SoloJiang approved these changes

@ClarkXia ClarkXia ClarkXia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luhc228 @ClarkXia @SoloJiang