Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: .ice ts type #4221

Merged
merged 4 commits into from
Apr 15, 2021
Merged

fix: .ice ts type #4221

merged 4 commits into from
Apr 15, 2021

Conversation

luhc228
Copy link
Collaborator

@luhc228 luhc228 commented Apr 13, 2021

Closed: #4209

ClarkXia
ClarkXia reviewed Apr 13, 2021
View reviewed changes
packages/plugin-app-core/src/generator/templates/common/render.ts.ejs Outdated
@@ -18,7 +18,7 @@
return ReactDOM.render(appInstance, rootEl);
}

export function unmount(appInstance, rootEl) {
export function unmount(rootEl) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

react 和 rax 参数不一致？

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

和 @SoloJiang 讨论过，需要兼容到以前用 react 写小程序的场景，这里暂且 ts-ignore 掉这里的 error

@luhc228 luhc228 requested a review from SoloJiang April 15, 2021 02:07
@luhc228 luhc228 merged commit 4c6c2d8 into release-next Apr 15, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix/ts-types branch April 15, 2021 03:19
@luhc228 luhc228 mentioned this pull request Apr 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClarkXia ClarkXia ClarkXia left review comments

@SoloJiang SoloJiang SoloJiang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luhc228 @ClarkXia @SoloJiang