-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: router url join is invalid in Windows #4265
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClarkXia
reviewed
Apr 25, 2021
另外路由 path 存在 |
ClarkXia
reviewed
Apr 26, 2021
ClarkXia
reviewed
Apr 27, 2021
SoloJiang
reviewed
Apr 27, 2021
SoloJiang
reviewed
Apr 27, 2021
SoloJiang
reviewed
Apr 27, 2021
ClarkXia
approved these changes
Apr 28, 2021
SoloJiang
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed: #4238
问题
path.join()
在 Windows 系统下的路径拼接的结果如下面的例子所示:这样的路由很明显是不存在的,导致 SSR 渲染时找不到对应要渲染的页面。我们期望拼接后的路由是
/about
path
模块解决
参考
url-join
代码实现一套路由路径拼接的方法