fix: store error in vite HMR #4893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4893 +/- ##
==========================================
- Coverage 25.46% 25.38% -0.08%
==========================================
Files 192 193 +1
Lines 4835 4888 +53
Branches 1099 1109 +10
==========================================
+ Hits 1231 1241 +10
- Misses 3548 3591 +43
Partials 56 56
|
ClarkXia
reviewed
Nov 10, 2021
| const pageStoreRegExp = /src\/pages\/\w+\/store.[jt]s$/; | ||
| if (appStoreRegExp.test(id) || pageStoreRegExp.test(id)) { | ||
| const s = new MagicString(code); | ||
| const matchedResult = code.match(/(createStore\s*,?).*} from ["']ice['"]/); |
ClarkXia
reviewed
Nov 10, 2021
| * import { Plugin } from 'ice'; | ||
| * import { createStore } from '@ice/store'; | ||
| */ | ||
| s.overwrite(matchedResult.index, matchedResult.index + matchedResult[1].length, ''); |
There was a problem hiding this comment.
单独 import { createStore } from 'ice'; 的场景结果是什么样的
There was a problem hiding this comment.
变成 import { } from 'ice';
There was a problem hiding this comment.
单独 import { createStore } from 'ice'; 应该直接替换成 import { createStore } from '@ice/store';
ClarkXia
reviewed
Nov 10, 2021
| const importDeclarations = getImportDeclarations(); | ||
|
|
||
| return { | ||
| enforce: 'pre', |
There was a problem hiding this comment.
用 es-module-lexer 的话就不能在 pre 阶段了
| const [imports] = parse(code); | ||
| const s = new MagicString(code); | ||
| for (let index = 0; index < imports.length; index++) { | ||
| const importSpecifier = imports[0]; |
ClarkXia
reviewed
Nov 10, 2021
| const normalImportSources: { [key: string]: string[] } = {}; | ||
|
|
||
| importIdentifiersArray.forEach((importIdentifier: string) => { | ||
| const { value, type } = importDeclarations[importIdentifier]; |
There was a problem hiding this comment.
如果有一条不存在 理论上这个转化就没必要了，可以中断转化，并且输出一定的 warning 日志
ClarkXia
approved these changes
Nov 12, 2021
imsobear
approved these changes
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
问题
vite 项目下使用 store 会出现循环依赖的情况，从而导致 HMR 过程中发生报错：
can't read property store of null