feat: SSR in mode vite ssr #5045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release/2.5.0 #5045 +/- ##
=================================================
+ Coverage 30.06% 30.22% +0.15%
=================================================
Files 198 201 +3
Lines 5245 5271 +26
Branches 1279 1286 +7
=================================================
+ Hits 1577 1593 +16
- Misses 3379 3389 +10
Partials 289 289
|
luhc228
reviewed
Jan 4, 2022
luhc228
approved these changes
Jan 6, 2022
luhc228
approved these changes
Jan 7, 2022
imsobear
reviewed
Jan 7, 2022
| ], | ||
| "$store": [ | ||
| "src/store1.ts" | ||
| ] |
| @@ -52,7 +52,7 @@ export function runApp(appConfig?: IAppConfig) { | |||
| // set History before GID | |||
| initHistory && initHistory(appConfig as any); | |||
| <% } %> | |||
| if (process.env.__IS_SERVER__) return; | |||
| if ((typeof global !== 'undefined' && (global as any).__IS_SERVER__) || process.env.__IS_SERVER__) return; | |||
There was a problem hiding this comment.
为什么不复用 process.env.__IS_SERVER__？
There was a problem hiding this comment.
是不是全部统一到运行时判断：globalThis.IS_SERVER
| @@ -17,7 +28,7 @@ export default async function ssgRender(options) { | |||
| const { path = '', getInitialProps, ...rest } = flatRoute; | |||
|
|
|||
| const keys = []; | |||
| pathToRegexp(path, keys); | |||
| (pathToRegexp.default || pathToRegexp)(path, keys); | |||
There was a problem hiding this comment.
在标准的 esm 规范里面 import * as pathToRegexp from 'path-to-regexp'; 被认为是导入的是一个对象，而 import pathToRegexp from 'path-to-regexp'; 是默认的方法导出。 webpack 下对上述两种方式进行了兼容，而 vite 模式下不会
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #4651