Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: miniapp app lifecycle is invalid #5263

Merged
merged 2 commits into from
Apr 7, 2022
Merged

fix: miniapp app lifecycle is invalid #5263

merged 2 commits into from
Apr 7, 2022

Conversation

SoloJiang
Copy link
Collaborator

  1. 解决小程序独有生命周期未生效的问题
  2. 在其他端收集这部分生命周期的回调函数几乎没有副作用

@SoloJiang SoloJiang requested review from ClarkXia and maoxiaoke April 2, 2022 03:24
@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2022 •
edited
Loading

Codecov Report

Merging #5263 (9b20fac) into release-next (69c9c94) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           release-next    #5263      +/-   ##
================================================
- Coverage         30.55%   30.52%   -0.03%     
================================================
  Files               204      204              
  Lines              5456     5461       +5     
  Branches           1280     1280              
================================================
  Hits               1667     1667              
- Misses             3754     3759       +5     
  Partials             35       35
Impacted Files Coverage Δ
...kages/create-app-shared/src/collectAppLifeCycle.ts 0.00% <0.00%> (ø)

@ClarkXia ClarkXia changed the base branch from master to release-next April 7, 2022 03:21
@ClarkXia ClarkXia changed the base branch from release-next to master April 7, 2022 03:23
@ClarkXia ClarkXia changed the base branch from master to release-next April 7, 2022 03:24
@ClarkXia ClarkXia merged commit 54e6873 into release-next Apr 7, 2022
@ClarkXia ClarkXia deleted the fix/miniapp-app-lifecycle branch April 7, 2022 03:33
@ClarkXia ClarkXia mentioned this pull request Apr 7, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maoxiaoke maoxiaoke maoxiaoke approved these changes

@ClarkXia ClarkXia ClarkXia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SoloJiang @codecov-commenter @ClarkXia @maoxiaoke