Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: treat kraken as web #5319

Merged
merged 4 commits into from
Jun 8, 2022
Merged

Fix: treat kraken as web #5319

merged 4 commits into from
Jun 8, 2022

Conversation

wssgcg1213
Copy link
Collaborator

Treat kraken as web, prevent injecting Weex modules.

@wssgcg1213 wssgcg1213 requested review from ClarkXia and SoloJiang May 7, 2022 07:10
@ClarkXia
Copy link
Collaborator

ClarkXia commented May 9, 2022

isKraken is defined but never used

@wssgcg1213
Copy link
Collaborator Author

isKraken is defined but never used

Removed.

@codecov-commenter
Copy link

Codecov Report

Merging #5319 (07213ff) into master (f5067ec) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5319   +/-   ##
=======================================
  Coverage   30.52%   30.52%           
=======================================
  Files         204      204           
  Lines        5461     5461           
  Branches     1280     1280           
=======================================
  Hits         1667     1667           
  Misses       3759     3759           
  Partials       35       35           
Impacted Files Coverage Δ
packages/create-app-shared/src/index.ts 0.00% <0.00%> (ø)

@ClarkXia ClarkXia changed the base branch from master to release-next June 8, 2022 02:19
@ClarkXia ClarkXia merged commit 82543dd into release-next Jun 8, 2022
@ClarkXia ClarkXia deleted the fix/kraken-to-web branch June 8, 2022 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants