Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support nodeExternals #5474

Merged
merged 4 commits into from
Aug 30, 2022
Merged

Conversation

luhc228
Copy link
Collaborator

@luhc228 luhc228 commented Aug 29, 2022

支持 nodeExternals 选项,ssr 打包的时候可以把 node_modules 的依赖 external 出去

@luhc228 luhc228 requested a review from ClarkXia August 29, 2022 03:26
@luhc228 luhc228 self-assigned this Aug 29, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #5474 (206485e) into release-next (0a3b166) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           release-next    #5474      +/-   ##
================================================
+ Coverage         30.46%   30.48%   +0.02%     
================================================
  Files               204      204              
  Lines              5476     5478       +2     
  Branches           1343     1344       +1     
================================================
+ Hits               1668     1670       +2     
  Misses             3773     3773              
  Partials             35       35              
Impacted Files Coverage Δ
packages/plugin-ice-ssr/src/index.ts 52.23% <100.00%> (+0.72%) ⬆️

@luhc228 luhc228 merged commit de9092e into release-next Aug 30, 2022
@luhc228 luhc228 deleted the feat/support-nodeExternals branch August 30, 2022 04:17
@luhc228 luhc228 mentioned this pull request Sep 14, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants