Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enhance memory router #5800

Merged
merged 4 commits into from
Jan 11, 2023
Merged

feat: enhance memory router #5800

merged 4 commits into from
Jan 11, 2023

Conversation

ClarkXia
Copy link
Collaborator

@ClarkXia ClarkXia commented Jan 9, 2023

Fix #5774

luhc228
luhc228 reviewed Jan 11, 2023
View reviewed changes
packages/runtime/src/runClientApp.tsx
if (initialIndex >= 0) {
memoryOptions.initialIndex = initialIndex;
} else {
console.error(`path: ${initialEntry} do not match any initialEntries ${memoryOptions.initialEntries}`);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

统一直接用 consola(logger) 吧

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这是 runtime

@ClarkXia ClarkXia requested a review from luhc228 January 11, 2023 03:39
@ClarkXia ClarkXia merged commit 66cd9df into release/3.0 Jan 11, 2023
@ClarkXia ClarkXia deleted the fix/memory-router branch January 11, 2023 09:36
@ClarkXia ClarkXia mentioned this pull request Jan 11, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luhc228 luhc228 luhc228 approved these changes

@wssgcg1213 wssgcg1213 wssgcg1213 approved these changes

@chenjun1011 chenjun1011 Awaiting requested review from chenjun1011

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ClarkXia @wssgcg1213 @luhc228