Fix/rax-compat jsx runtime #5803

wssgcg1213 · 2023-01-09T13:40:40Z

修复 rax-compat 插件下 react createElement 没有劫持实现 compatStyle 的 bug
修复 rax-compat 插件下必须引入 createElemenet 变量的问题, 在实现上由 plugin-rax-compat 注入判断, 并修改 swcOptions.jsc.react.runtime 的值

Close #5789

packages/ice/src/commands/build.ts

packages/rax-compat/src/create-element.ts

ClarkXia · 2023-01-12T03:35:36Z

补充下 changelog

fix: jsx runtime for rax-compat

6baac6b

wssgcg1213 changed the base branch from master to release/3.0 January 9, 2023 13:40

wssgcg1213 changed the title ~~Fix/rax compat jsx runtime~~ [WIP] Fix/rax compat jsx runtime Jan 9, 2023

wssgcg1213 added 3 commits January 9, 2023 21:54

fix: optional children

4824e5e

fix: array key validation

a601c10

fix: eslint check

2b15cdc

wssgcg1213 changed the title ~~[WIP] Fix/rax compat jsx runtime~~ Fix/rax-compat jsx runtime Jan 10, 2023

wssgcg1213 requested review from answershuto and ClarkXia and removed request for answershuto January 10, 2023 16:32

wssgcg1213 self-assigned this Jan 10, 2023

wssgcg1213 added the bug label Jan 10, 2023

wssgcg1213 added 2 commits January 11, 2023 10:37

fix: add default commandArgs target

378ec97

fix: createElement children args

536f3af

answershuto reviewed Jan 11, 2023

View reviewed changes

packages/ice/src/commands/build.ts Show resolved Hide resolved

packages/rax-compat/src/create-element.ts Show resolved Hide resolved

answershuto previously approved these changes Jan 12, 2023

View reviewed changes

docs: add changelog and bump version

1b4a19e

wssgcg1213 dismissed answershuto’s stale review via 1b4a19e January 12, 2023 03:39

ClarkXia approved these changes Jan 12, 2023

View reviewed changes

answershuto approved these changes Jan 12, 2023

View reviewed changes

ClarkXia merged commit 0817129 into release/3.0 Jan 12, 2023

ClarkXia deleted the fix/rax-compat-jsx-runtime branch January 12, 2023 04:04

Provide feedback