fix: prebundle esm module error #5935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luhc228
changed the title
answershuto
reviewed
Feb 17, 2023
ClarkXia
reviewed
Feb 17, 2023
| // export * from '...' | ||
| str.overwrite(start, end, filePath, { contentOnly: true }); | ||
| } | ||
| str.overwrite(start, end, filePath, { contentOnly: true }); |
There was a problem hiding this comment.
Mark：transformCjsImport 在 server 格式为 cjs，并且不希望 bundle 三方依赖的时候会用到。但框架推荐 esm 的格式，对于 cjs 下的预编译暂时不支持。
ClarkXia
reviewed
Feb 17, 2023
Comment on lines
-141
to
+153
| if (!resolvedEntryPoint) { | ||
| resolvedEntryPoint = pkgJSON['main'] || 'index.js'; | ||
| } | ||
| // resolve "exports.import" field or "module" field | ||
| const resolvedEntryPoint = (resolveExports(pkgJSON, entry) || resolveLegacy(pkgJSON) || 'index.js') as string; |
There was a problem hiding this comment.
这个的 resolveLegacy 是会走的 main 入口吗
There was a problem hiding this comment.
ClarkXia
previously approved these changes
Feb 17, 2023
answershuto
previously approved these changes
Feb 17, 2023
ClarkXia
approved these changes
Feb 17, 2023
answershuto
approved these changes
Feb 20, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
预打包依赖过程，由于预打包依赖的格式是 cjs，如果依赖中的依赖是被 external 的，那么预构建产物中将会是 require('xxx')。Server Bundle 如果是在 ESM 下运行的话，就会直接报错
evanw/esbuild#1921 (comment)