Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: when code has declare @jsx createElement comment, swc config runtime: 'classic' #5976

Merged
merged 5 commits into from
Feb 27, 2023
Merged

fix: when code has declare @jsx createElement comment, swc config runtime: 'classic' #5976

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d9e31e8
feat: 遇到注释信息 应该走 classic 的编译模式
MrpandaLiu Feb 27, 2023
ca26178
chore: add version and changelog
MrpandaLiu Feb 27, 2023
6dd3f5d
chore: add changesets
MrpandaLiu Feb 27, 2023
54bb555
feat: hasJSXComment 的逻辑放在 isRaxComponent
MrpandaLiu Feb 27, 2023
8b43eb4
feat: 内部声明
MrpandaLiu Feb 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/spicy-dryers-melt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@ice/plugin-rax-compat': major
---

- [fix] Using runtime: 'classic' mode when source has declare `@jsx createElement` comment
4 changes: 4 additions & 0 deletions packages/plugin-rax-compat/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## 0.1.4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

按照卓凌提的来就好了，这个不需要手动提交了


- [fix] Using runtime: 'classic' mode when source has declare `@jsx createElement` comment

## 0.1.3

- [refactor] Using rax-compat/jsx-runtime to support rax components
Expand Down
13 changes: 12 additions & 1 deletion packages/plugin-rax-compat/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,18 @@ const plugin: Plugin<CompatRaxOptions> = (options = {}) => ({
config.swcOptions = merge(config.swcOptions || {}, {
compilationConfig: (source: string) => {
const isRaxComponent = /from\s['"]rax['"]/.test(source);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package 里面 version 加一下，changelog 补充

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

用 changeset 流程：

  1. 不需要修改版本号
  2. 项目根路径下执行 pnpm run changeset, 根据 cli 提示操作
  3. 提交所有文件

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

push了

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

用 changeset 流程：

  1. 不需要修改版本号
  2. 项目根路径下执行 pnpm run changeset, 根据 cli 提示操作
  3. 提交所有文件

这个好像还没有补充到 CONTRIBUTING.md 中

if (isRaxComponent) {
const hasJSXComment = source.indexOf('@jsx createElement') !== -1;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个检测可以卸载判断条件内部，提升效率

if (hasJSXComment) {
return {
jsc: {
transform: {
react: {
runtime: 'classic',
},
},
},
};
} else if (isRaxComponent) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hasJSXComment 的逻辑放在 isRaxComponent 吧，这个逻辑只在 rax 下生效。

return {
jsc: {
transform: {
Expand Down