Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable hmr to avoid reload #6004

Merged
merged 6 commits into from
Mar 3, 2023
Merged

fix: enable hmr to avoid reload #6004

merged 6 commits into from
Mar 3, 2023

Conversation

ClarkXia
Copy link
Collaborator

@ClarkXia ClarkXia commented Mar 3, 2023

问题原因 #5535

导出 pageConfig / dataLoader 组件降级为 hot reload
仅仅为组件的导出,支持 fast refresh(原因为 env 插件导致每次认为模块都有变化)

@ClarkXia ClarkXia requested review from chenjun1011 and luhc228 March 3, 2023 08:47
@ClarkXia ClarkXia added the need review Need Review label Mar 3, 2023
@ClarkXia ClarkXia removed the need review Need Review label Mar 3, 2023
luhc228
luhc228 previously approved these changes Mar 3, 2023
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release/next@c23c10e). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 9cd2230 differs from pull request most recent head ed29192. Consider uploading reports for the commit ed29192 to get more accurate results

Additional details and impacted files
@@               Coverage Diff               @@
##             release/next    #6004   +/-   ##
===============================================
  Coverage                ?   81.94%           
===============================================
  Files                   ?      197           
  Lines                   ?    18104           
  Branches                ?     2356           
===============================================
  Hits                    ?    14836           
  Misses                  ?     3233           
  Partials                ?       35           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

wssgcg1213
wssgcg1213 previously approved these changes Mar 3, 2023
luhc228
luhc228 previously approved these changes Mar 3, 2023
@ClarkXia ClarkXia dismissed stale reviews from luhc228 and wssgcg1213 via 87caf7d March 3, 2023 09:29
@ClarkXia ClarkXia requested review from wssgcg1213 and luhc228 March 3, 2023 09:29
@ClarkXia ClarkXia merged commit 18ea5b2 into release/next Mar 3, 2023
@ClarkXia ClarkXia deleted the fix/hmr branch March 3, 2023 10:03
@ClarkXia ClarkXia mentioned this pull request Mar 3, 2023
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need review Need Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants