Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: reduce bundle size by remove runtime module #6850

Merged
merged 5 commits into from
Apr 15, 2024

Conversation

ClarkXia
Copy link
Collaborator

@ClarkXia ClarkXia commented Apr 1, 2024

Remove routes config runtime if necessary.

@ClarkXia ClarkXia changed the title [WIP] Fix: optimize runtime size [WIP] Fix: reduce bundle size by remove runtime module Apr 1, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 93.33333% with 2 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (release/next@ee14962). Click here to learn what that means.

Files Patch % Lines
packages/runtime/src/routes.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             release/next    #6850   +/-   ##
===============================================
  Coverage                ?   79.11%           
===============================================
  Files                   ?      221           
  Lines                   ?    19739           
  Branches                ?     2508           
===============================================
  Hits                    ?    15616           
  Misses                  ?     4085           
  Partials                ?       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClarkXia ClarkXia changed the title [WIP] Fix: reduce bundle size by remove runtime module Fix: reduce bundle size by remove runtime module Apr 2, 2024
@ClarkXia ClarkXia requested a review from luhc228 April 2, 2024 03:32
@ClarkXia ClarkXia added the need review Need Review label Apr 9, 2024
luhc228
luhc228 previously approved these changes Apr 10, 2024
@ClarkXia ClarkXia merged commit d5c378b into release/next Apr 15, 2024
7 checks passed
@ClarkXia ClarkXia deleted the fix/routes-config branch April 15, 2024 07:15
@ClarkXia ClarkXia mentioned this pull request Apr 17, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need review Need Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants