Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

支持获取自定义的 Agent 启动参数 #163

Closed
wants to merge 3 commits into from

Conversation

dadiyang
Copy link
Contributor

@dadiyang dadiyang commented Apr 12, 2019

  1. 支持获取自定义的 Agent 启动参数 获取自定义的 Agent 启动参数 #164
  2. Advice添加获取目标类加载器的快捷方法 Advice中获取ClassLoader很麻烦 #161

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-io
Copy link

codecov-io commented Apr 12, 2019

Codecov Report

Merging #163 into develop-for-20190410 will decrease coverage by 0.09%.
The diff coverage is 0%.

Impacted file tree graph

@@                   Coverage Diff                   @@
##           develop-for-20190410     #163     +/-   ##
=======================================================
- Coverage                 43.03%   42.94%   -0.1%     
=======================================================
  Files                        98       98             
  Lines                      4136     4147     +11     
  Branches                    667      672      +5     
=======================================================
+ Hits                       1780     1781      +1     
- Misses                     2174     2185     +11     
+ Partials                    182      181      -1
Impacted Files Coverage Δ
...a/com/alibaba/jvm/sandbox/agent/AgentLauncher.java 0% <0%> (ø) ⬆️
...va/com/alibaba/jvm/sandbox/core/CoreConfigure.java 50% <0%> (-1.48%) ⬇️
...m/alibaba/jvm/sandbox/api/listener/ext/Advice.java 38.18% <0%> (-1.11%) ⬇️
...m/sandbox/core/manager/impl/DefaultConfigInfo.java 0% <0%> (ø) ⬆️
...a/jvm/sandbox/api/listener/ext/AdviceListener.java 20% <0%> (ø) ⬆️
...andbox/api/listener/ext/AdviceAdapterListener.java 43.66% <0%> (ø) ⬆️
...jvm/sandbox/core/server/jetty/JettyCoreServer.java 0% <0%> (ø) ⬆️
.../sandbox/core/util/matcher/UnsupportedMatcher.java 0% <0%> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe006a1...ae11707. Read the comment docs.

String sandboxHome = featureMap == null || !featureMap.containsKey(KEY_SANDBOX_HOME)
? DEFAULT_SANDBOX_HOME : featureMap.get(KEY_SANDBOX_HOME);
// 保留 featureMap 中的所有配置项
Map<String, String> map = copyMap(featureMap);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

通过一个 map 来存放,最后再统一序列化,这样代码更加清晰,更易于维护。

* @param key 键
* @return 值
*/
String getProperty(String key);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

提供两个获取启动参数的方法,一个是获取单个的,一个是获取全部的。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants