Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add config server proto v2 #1516

Merged
merged 11 commits into from
Jun 12, 2024
Merged

Conversation

yyuuttaaoo
Copy link
Collaborator

@yyuuttaaoo yyuuttaaoo commented Jun 3, 2024

protobuf定义基本与讨论 #1491 中最后的结论一致。但有以下修改:

  1. 放弃与v1版本的兼容,因为tags字段从string变更为AgentGroupTag,必然带来不兼容。
  2. 删除了未定义行为的字段,和高度重复的结构,简化proto定义。

后续兼容策略:

  1. proto v2与v1在不同命名空间,故可以在1个binary中共存
  2. config server v1版本特性depreciated,在半年后彻底删除
  3. 当v2版本client和server都完成后,默认切换到v2,使用v1需打开兼容开关

@yyuuttaaoo yyuuttaaoo added the feature request New feature request label Jun 3, 2024
@Takuka0311
Copy link
Collaborator

这个协议放在了v2的目录下,之前的要不要转移到一个“v1”的目录?

@yyuuttaaoo
Copy link
Collaborator Author

yyuuttaaoo commented Jun 3, 2024

这个协议放在了v2的目录下,之前的要不要转移到一个“v1”的目录?

可能老的直接后面删掉,或者等user.proto也有v2后一齐移动,并更新CMakeList.txt

@yyuuttaaoo yyuuttaaoo closed this Jun 3, 2024
@yyuuttaaoo yyuuttaaoo reopened this Jun 3, 2024
config_server/protocol/v2/README.md Show resolved Hide resolved
config_server/protocol/v2/README.md Show resolved Hide resolved
config_server/protocol/v2/agent.proto Show resolved Hide resolved
config_server/protocol/v2/README.md Outdated Show resolved Hide resolved
@yyuuttaaoo yyuuttaaoo modified the milestone: v2.2 Jun 12, 2024
@yyuuttaaoo yyuuttaaoo merged commit 71f894d into alibaba:main Jun 12, 2024
15 checks passed
@yyuuttaaoo yyuuttaaoo deleted the configserver_v2 branch June 12, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants