Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support config server v2 provider #1633

Merged
merged 62 commits into from
Jul 31, 2024

Conversation

quzard
Copy link
Collaborator

@quzard quzard commented Jul 22, 2024

No description provided.

Copy link
Collaborator

@henryzhx8 henryzhx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. ProcessConfig的checkconfigdiff不应该和pipelineconfig的checkconfigdiff完全复用,互相之间明显有差异。
  2. ProcessConfigManager放在pipeline目录下显然不合适。

@henryzhx8 henryzhx8 added the feature request New feature request label Jul 23, 2024
@henryzhx8 henryzhx8 added this to the v2.2 milestone Jul 23, 2024
@quzard
Copy link
Collaborator Author

quzard commented Jul 23, 2024

  1. ProcessConfig的checkconfigdiff不应该和pipelineconfig的checkconfigdiff完全复用,互相之间明显有差异。
  2. ProcessConfigManager放在pipeline目录下显然不合适。

ProcessConfigManager开发时再一起改了

@quzard quzard requested a review from yyuuttaaoo July 23, 2024 06:26
core/config/provider/CommonConfigProvider.cpp Outdated Show resolved Hide resolved
core/config/provider/CommonConfigProvider.h Outdated Show resolved Hide resolved
core/config/provider/CommonConfigProvider.cpp Show resolved Hide resolved
core/config/provider/CommonConfigProvider.cpp Outdated Show resolved Hide resolved
core/config/provider/CommonConfigProvider.cpp Outdated Show resolved Hide resolved
core/config/provider/CommonConfigProvider.cpp Outdated Show resolved Hide resolved
core/config/provider/CommonConfigProvider.h Outdated Show resolved Hide resolved
core/CMakeLists.txt Outdated Show resolved Hide resolved
@yyuuttaaoo yyuuttaaoo requested a review from henryzhx8 July 30, 2024 13:10
@quzard quzard merged commit 67bd2d5 into alibaba:main Jul 31, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants